Responsive Product Preview Card Component

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge !

  I have some feedback for you if you want to improve your code.

  • You can use the <picture> tag when you have different versions of the same image. Using the <picture> tag will help you to load the correct image for the user's device saving bandwidth and improving performance. You can read more about this here.

  Example:

  <picture>
  	<source media="(max-width: 1200px)" srcset="./images/image-product-mobile.jpg">
  	<img src="./images/image-product-desktop.jpg" alt="{your alt text goes here}">
  </picture>
  

  • You should use the mobile first workflow. Mobile-first design is a strategy for designing websites and applications that prioritize the mobile user experience. It involves designing for mobile devices first, then scaling up to larger screens such as desktops and tablets. This approach ensures that the mobile experience is optimized for users on all devices, while also providing a consistent user experience across all platforms.

  HTML:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

  • You could use the <del> tag to indicate the price that was before the discount. Additionally, you can use a sr-only class to describe the discount. This will help screen reader users to understand that the price was discounted.

  Example:

  <del><span class="sr-only">Old price: </span>$169.99</del>
  

  • The alt attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.

  • Not all images should have alt text. The cart-icon is a decorative image, it does not add any information to the page. You should use an empty alt attribute instead of a descriptive one. You can read more about this here.

  If you want to learn more about the alt attribute, you can read this article.

  • For specificity reasons you should work with classes instead of ids because they are more reusable. You can use ids to work with JavaScript, but you should use classes to style your elements. You can read more about this here.

  CSS:

  • You should use the border-box: box-sizing property to make the width and height properties include the padding and border of the element. This will make it easier to calculate the size of an element. You can read more about this here.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  0

  ---

  

  Adhitya Aditama Nugraha•180

  @aaditamanugrahaPosted almost 2 years ago

  @MelvinAguilar Thank you very much for the feedback given in this forum. I am very grateful for the assistance given and will use it as a consideration to improve my skills in the future.

  I am also impressed with your feedback and profile. After this, I will follow you and hope to get closer to you. I am confident that by getting closer, I will learn more from you and improve my skills in this field. 🙌

  0