Design comparison
Solution retrospective
tell me your opinion
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The image’s
alt tag
description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- This component requires the use of two images 🎑 at different breakpoints. The
picture
element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:📚
https://www.w3schools.com/html/html_images_picture.asp
- The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a
paragraph
element.
- Your "button" was created with the incorrect element. It should be created using the
button
element. So that when the user clicks on the button (with the help of JS) it should add the product to the cart.
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful0 - The image’s
- @catherineisonlinePosted almost 2 years ago
Looks cool. You might want to add transition not only during hover but also in none hover state because I notice transition when I hover over but when I hover out it's not the same and looks buggy 😊
Marked as helpful0@Mostafa-ninooPosted almost 2 years ago@catherineisonline understand you yes you are right it is not the same. thank you for helping.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord