Practice

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  0

  ---

  

  Samuel To•70

  @KarrimorRiflePosted almost 2 years ago

  @vcarames Yeah thanks man, was kind of lazy with this so I didn't use the main tag, I also didn't take into account accessibility issues, I shall adjust to do so here on out. Have a good one!

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @KarrimorRifle

  I am glad that I was able to help out!

  Keep it up!

  1
• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Hey there, nice solution! If you want to improve your code, make sure sure to use footer tag for your attribution div.

  You can read more about semantic html here: https://www.w3schools.com/html/html5_semantic_elements.asp

  IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩

  0