Product Preview Card Component using Grid

Community feedback

• Account deleted

  Hello!... Congratulations on completing this challenge. 🎉🎉🎉🎊

  Here some solutions to improve your code.

  CSS:

  I recommend you use CSS reset, because your css reset is not used.

  • Normalize CSS

  Your solution is very good, good job!!

  Happy coding🎉🎉🙃

  Marked as helpful

  0

  ---

  

  Deepali Panchal•310

  @Deepali25-KPosted almost 2 years ago

  @Khris26

  I sincerely appreciate the information you gave me regarding areas where I may improve; it will be beneficial when I approach my next project.

  0
• 

  Eileen dangelo•1,600

  @EileenpkPosted almost 2 years ago

  Hi Deepali, your project looks really good, it's organized, semantic, and clean. The only thing that I would change is maybe putting the <svg> tag into another file and then inserting it into the HTML as an <img>. It doesn't really matter on small projects but when code gets to be hundreds or more lines of code, anything we can do to make the code easier to read saves time down the line.

  Hope you found this helpful!

  • Let's connect on LinkedIn! - @Eileenpk

  Marked as helpful

  0

  ---

  

  Deepali Panchal•310

  @Deepali25-KPosted almost 2 years ago

  @Eileenpk

  Thank you for your feedback, I really appreciate it. :)

  0