Responsive product preview card component using Grid and Flexbox.
Design comparison
Solution retrospective
Any comment on how to improve the way I approached the project will be really appreciated. Thanks in advance.
Community feedback
- @NikolaD93Posted almost 2 years ago
Hello there! 👋
Congrats for completing the challenge! 🙌
I have a suggestion for you to improve your code:
1.Avoid to write internal CSS, it makes your code look untidy. So it is better to write external instead. 👇
https://www.w3schools.com/css/css_howto.asp
2.Make sure not to put everything in the div tag. It's better to write semantic HTML, for example everything should be in the main tag. Take a look at the documentation. 👇
https://www.w3schools.com/html/html5_semantic_elements.asp
Hope this was helpful for you!
Happy holidays! 🎉✌
Marked as helpful1@authenticoderPosted almost 2 years ago@Nikola1232456 Thank you. I really appreciate it.
1 - @Ambe-Mbong-NwiPosted almost 2 years ago
Nice job. To centralize your design on a page both vertically and horizontally, include
body{ margin: 0 auto; }
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord