Design comparison
Solution retrospective
All comment is welcomed thank you.
Community feedback
- @MelvinAguilarPosted 12 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
-
Wrap the main content in
<main>
tag. -
Use
<del>
to show the original price and asr-only
class for discount info. Example:<del><span class="sr-only">Old price: </span>$169.99</del>
-
Use
<img>
instead of background-image for product images. -
Use relative units like
em
orrem
for font-size. Resource ๐ -
Avoid uppercase text in HTML; use text-transform in CSS.
-
Apply global font-family:
--paragraph-font-family
to body or container instead of individually on each text element.
I hope you find it useful! ๐ Above all, the solution you submitted is great!
Happy coding!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord