Design comparison
Solution retrospective
Hi all, I have completed this challenge. But this is not still responsive as I will learn responsiveness now. Any feedback on HTML and CSS will be appreciated, as I have centered the card component in the view crudely.
Community feedback
- @MelvinAguilarPosted 10 months ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- Wrap the page's whole main content in the
<main>
tag.
- Use the
<footer>
tag to wrap the footer of the page instead of the<div class="attribution">
.
- The
<h1>
is the most important heading on the page, In this challenge the perfumer's name can be considered like the title of the page, so it should be the<h1>
- You could use the
<del>
tag to indicate the price that was before the discount.
-
The
alt
attribute should not contain the words "image", "photo", or "picture", because the image tag already conveys that information.If you want to learn more about the
alt
attribute, you can read this article. ๐.
I hope you find it useful! ๐
Happy coding!
1 - Wrap the page's whole main content in the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord