Perfume Advertisement Using CSS Positioning

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  Hey there, nice solution! If you want to improve your code, make sure sure to use footer tag for your attribution div.

  You can read more about semantic html here: https://www.w3schools.com/html/html5_semantic_elements.asp

  IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL 🤩

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="ad"> with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. for the <img> place "." in the src value : e.g. <img src="./images/icon-cart.svg" id="icon">

  To center a content on a page, add min-height:100vh; display: flex; align-items-center: justify-content: center; to the body. instead of giving .ad a margin value.

  #product-image a width of 100% , there is no need to give it a height value.

  Use rem or em as unit for the padding , margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful Happy coding

  0