Product Preview Card Component

Community feedback

• 

  Bryan Li•3,530

  @Zy8712Posted about 1 year ago

  Your website looks really solid. Nice work!!!

  The only additional piece of feedback I'd give (besides needing to use <img> and <main>) is to add a bit more spacing to the to and bottom of the page so it feels less claustrophobic. Spacing is pretty key in a good user experience.

  Besides that, I'd say your solution is pretty much one for one with the original design.

  1
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • Wrap the page's whole main content in the <main> tag.

  • The product image is not a decoration. You must not use the background-image property to add the product image. Instead, use the <img> tag to add the image. Use the background-image property only for decorative images that do not add any information to the page.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  1

  ---

  

  Sean Brookstein•150

  @CassiuSRSAPosted about 1 year ago

  @MelvinAguilar thank you so much for your input. I was having like an internal battle with myself on using image as a bg or an actual image haha will use actual img going forward thanks

  0