product preview

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

  Doing it in less than an hour is totally incredible, how fast

  HTML:

  • Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

  • You should use only one <h1> tag per page. The <h1> tag is the most important heading tag, This can confuse screen reader users and search engines. <h1 class="main-title-font"> $149.99 <span class="c-grey price-font-size-12-del">$169.99</span> </h1> is not a level-one heading element.

  • You could use the <del> tag to indicate the price that was before the discount. Additionally, you can use a sr-only class to describe the discount. This will help screen reader users to understand that the price was discounted.

  Example:

  <del><span class="sr-only">Old price: </span>$169.99</del>
  

  • You can use the <picture> tag when you have different versions of the same image. Using the <picture> tag will help you to load the correct image for the user's device saving bandwidth and improving performance. You can read more about this here.

  Example:

  <picture>
  	<source media="(max-width: 460px)" srcset="./images/image-product-mobile.jpg">
  	<img src="./images/image-product-desktop.jpg" alt="{your alt text goes here}">
  </picture>
  

  • The alt attribute is used to provide a text description of the image which is useful for screen reader users, assistive technology users, and search engine optimization. Add the alt attribute to the <img> tag

  CSS:

  • Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding and Happy New Year! 🎉🎊🎁

  3

  ---

  

  Mohamed Islam Arrar•100

  @Mohamed-ArarrPosted almost 2 years ago

  @MelvinAguilar Thanks a lot for your feedback, I found it very useful to improve my code.

  I'm working on improving it ASAP.

  Best regards.

  0
• 

  Martín•240

  @martinoruePosted almost 2 years ago

  Hi, excellent work!

  Maybe you forgot to add the button hover effect?

  And, in the case of the passed price, I think it would be nice to use the del element.

  1

  ---

  

  Mohamed Islam Arrar•100

  @Mohamed-ArarrPosted almost 2 years ago

  @martinorue thanks for your reaching out, indeed I forgot the button hover effect. your feedback is very helpful

  best regard.

  0