Skip to content
Submitted 3 months ago

Product preview card component

Elton Santos•40
@eltonSSilv
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

estou gostando da organização que estou aplicando em meus codigos, sendo assim facilitando futuras manutenções, pretendo deixar meus projetos menos estaticos

What challenges did you encounter, and how did you overcome them?

meu maior desafio foi a organização e localização dos elementos, tentei deixaar com menos codigos e gostei do resultado final

What specific areas of your project would you like help with?

gostaria de tentar escrever menos linhas de codigos e a organização dos blocos e dicas livres para melhorias

Community feedback

  • Teodor Jenkler•3,820
    @TedJenklerPosted 3 months ago

    Hi @eltonSSilv,

    Nice project! I noticed that your project isn't responsive. I believe this is because you didn’t follow a mobile-first approach. To fix this, make sure to remove all overflow: hidden properties and ensure the body takes up the full width and height without overflowing.

    Another point is that you're nesting your components incorrectly in terms of semantics, which is actually worse than not using semantics at all. Right now, you're essentially telling screen readers that this is a navbar.

    As a challenge, you could try to simplify the project using only three div containers and flexbox. It’s definitely doable and could help clean up your code.

    Overall, your project looks good! Try to incorporate these changes, and it will be perfect.

    Keep up the great work!

    Best, Teodor

    Marked as helpful
    1
    Elton Santos•40
    @eltonSSilvPosted 3 months ago

    Hi, @TedJenkler thank you very much for the feedback, I'll pay more attention to this, I'm just starting out and this feedback is helping me a lot.

    1
  • Svitlana Suslenkova•5,360
    @SvitlanaSuslenkovaPosted 3 months ago

    Please, consider to add body {min-height: 100vh;} in desktop css. It will help to center your project. Hope you found this comment helpful :)

    Marked as helpful
    1
    Elton Santos•40
    @eltonSSilvPosted 3 months ago

    thanks, i will @SvitlanaSuslenkova

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord