@TedJenkler
Posted
Hi @eltonSSilv,
Nice project! I noticed that your project isn't responsive. I believe this is because you didn’t follow a mobile-first approach. To fix this, make sure to remove all overflow: hidden properties and ensure the body takes up the full width and height without overflowing.
Another point is that you're nesting your components incorrectly in terms of semantics, which is actually worse than not using semantics at all. Right now, you're essentially telling screen readers that this is a navbar.
As a challenge, you could try to simplify the project using only three div containers and flexbox. It’s definitely doable and could help clean up your code.
Overall, your project looks good! Try to incorporate these changes, and it will be perfect.
Keep up the great work!
Best, Teodor
Marked as helpful
@eltonSSilv
Posted
Hi, @TedJenkler thank you very much for the feedback, I'll pay more attention to this, I'm just starting out and this feedback is helping me a lot.
