Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card Component

Trisha R 110

@cheribella

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I am practicing my skills in HTML and CSS currently. I bet my work is not perfectly structured. Any form of feedback is very much appreciated.

Community feedback

Fer 3,970

@fernandolapaz

Posted

Hi 👋, just a couple of things that may interest you:

HTML / ACCESSIBILITY:

  • The <h1> element doesn't seem to be suitable for the price (headings should not be used for styling). But if you think it's a heading, perhaps it would be better to use <h2> since although it is allowed to use more than one <h1> it is not considered a good practice
  • The image of the perfume is a meaningful image and in case the user can't see it, the alt text should give a description.

CSS:

  • You should use min-height: 100vh; for the body instead of max-height if you want the content to be centered on the page.

I hope you find it useful, any questions do not hesitate 🙂

Nice solution.

Regards,

Marked as helpful

1

Trisha R 110

@cheribella

Posted

@fernandolapaz Thank you so much!

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord