Product Preview Card Component

Community feedback

• 

  Fer•3,970

  @fernandolapazPosted over 1 year ago

  Hi 👋, just a couple of things that may interest you:

  HTML / ACCESSIBILITY:

  • The <h1> element doesn't seem to be suitable for the price (headings should not be used for styling). But if you think it's a heading, perhaps it would be better to use <h2> since although it is allowed to use more than one <h1> it is not considered a good practice

  • The image of the perfume is a meaningful image and in case the user can't see it, the alt text should give a description.

  CSS:

  • You should use min-height: 100vh; for the body instead of max-height if you want the content to be centered on the page.

  I hope you find it useful, any questions do not hesitate 🙂

  Nice solution.

  Regards,

  Marked as helpful

  1

  ---

  

  Trisha R•110

  @cheribellaPosted over 1 year ago

  @fernandolapaz Thank you so much!

  1