Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

Abu Salman 190

@AbuSalman143

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

HTML 🏷️:

  • This solution contains some minor semantic issues which may cause lack accessibility
  • The word PARFUM is not seems right, you can better change to Perfume
  • The <p class="subheading">PARFUM</p>, must want to be changed to normal case like Perfume
  • Providing uppercase letter to them is not a good practice and the screen reader will read it as letter by letter like P, E, R etc.
  • Don't worry we can use text-transform: uppercase to transform the letter and letter-spacing: 1rem for the text Perfume
  • And another thing that the old price is not being properly announced, you have used p element for that.
  • Actually there's a native html element which comes handy in these situations. it is del element
  • So you can use like this <del>$169.99</del>
  • These are the tips which improves the accessibility in real world situations.
  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

1

Abu Salman 190

@AbuSalman143

Posted

Thank You so much for given some helpful suggestions i will try to improve it thank you @0xAbdulKhalid

0

@0xabdulkhaliq

Posted

@AbuSalman143 Glad you found it helpful ! 🤠

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord