Skip to content
Submitted about 2 months ago

Product preview card component

Alexander Gusev•170
@WaRaGiSmYnIcKnAmE
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What challenges did you encounter, and how did you overcome them?

While working, I encountered a problem on mobile devices due to the button sticking when pressed. Fixed the entire line that I checked in the manual that I often use Doka-guide

@media (any-hover: hover) {
    button:hover {
        background-color: hsl(157, 37%, 14%);
    }
}

Community feedback

  • Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Hello again, Incredible work on this! You’re making great strides, and I have a couple of suggestions that might push it even further…

    • These <span> should really have semantic tags like headings (<h1> to <h6>) and paragraphs (<p>) convey structure and meaning to content, improving accessibility, SEO, and readability by helping search engines and screen readers interpret the content.
    <span class="item-class">Perfume</span>

    • Line height is usually unitless to scale proportionally with the font size, keeping text readable across different devices. Best practice is to use a unitless value like 1.5 for flexibility. Avoid using fixed units like px or %, as they don't adapt well to changes in font size or layout.

    • Using rem or em units in @media queries is better than px because they are relative units that adapt to user settings, like their preferred font size. This makes your design more responsive and accessible, ensuring it looks good on different devices and respects user preferences.

    • I think you can benefit from using a naming convention like BEM (Block, Element, Modifier) is beneficial because it makes your CSS more organized, readable, and easier to maintain. BEM helps you clearly understand the purpose of each class, avoid naming conflicts, and create reusable components, leading to a more scalable codebase. For more details BEM,

    You’re doing so well, and I hope this feedback is helpful! Keep honing your skills and remember to enjoy the process—you’re on a great path. Stay motivated, and happy coding! 🎯

    Marked as helpful
    1
    Alexander Gusev•170
    @WaRaGiSmYnIcKnAmEPosted about 2 months ago

    Hello, @Stroudy! I started frontend just a couple of months ago, when I had a desire to create my own website. Thanks to your comments, I began to make the layout more competently, and most importantly, quickly!

    1
    Steven Stroud•11,910
    @StroudyPosted about 2 months ago

    Hey @WaRaGiSmYnIcKnAmE, This feedback does not mean you have done anything incorrectly, Take it slow, Its not a race, Your smashing it and when learning there is so much to take in. You did a great job with this solution, Learning the fundamentals of coding is a marathon, You will only get better, Look at where you are now and where you was just a few months ago, You got this bro! 💪

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord