FEM_product-preview-card-component

Community feedback

• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Congrats on completing your first challenge!🎊🎆

  • The image’s alt tag description needs to be improved upon. Assume that you are describing the image to a someone over the phone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎄🎁

  1

  ---

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  • Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • Move all of these properties to the body and change height: 98vh; to min-height: 100vh;

  main {
      display: flex;
      flex-direction: column;
      justify-content: center;
      align-items: center;
      height: 98vh;
  }
  

  • Implement a Mobile First approach 📱 > 🖥 Mobile devices are now the dominant 👑way in which people browse the web, it is critical that your website/content looks presentable on all mobile devices.

  More Info: 📚

  Mobile First

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  1

  

  Sang Dang•230

  @Sang-DangPosted almost 2 years ago

  @vcarames thank you so much!

  1