Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

HTML and CSS grid

Eray 70

@eraybel

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • Do not forgot to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.
  • To properly center your content to your page, you will want to add the following to your body (this method uses CSS Grid):
body {
    min-height: 100vh;
    display: grid;
    place-content: center;
}

More Info:📚

Centering in CSS

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

More Info:📚

https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

Here is an example of how it works: EXAMPLE

Syntax:

  <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>

More Info:📚

https://www.w3schools.com/html/html_images_picture.asp

  • The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a paragraph element.
  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

More Info:📚

Del Element

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🎄🎁

0

@VCarames

Posted

@eraybel

NEVER ❌ do this as it creates accessibility issues for users and it is outdated.

html {
  font-size: 14px;
}
  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-sizeand other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.
  • Implement a Mobile First approach 📱 > 🖥 Mobile devices are now the dominant way in which people browse the web, it is critical that your website/content looks presentable on all mobile devices.

More Info:📚

Mobile First

  • Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

Here are some examples that you can freely use:

Josh Comeau Reset

Eric Meyer Reset

Marked as helpful

0
Eray 70

@eraybel

Posted

@vcarames Hello, thanks for your reply, I will correct any mistakes I missed and will look into them.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord