Product preview card component

Community feedback

• 

  paulDev•500

  @dev-paulLPosted 5 days ago

  Hi, quick review, I've probably missed things;

  • Use <picture>: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/picture.

  • If you use <h3> in a real website, make sure h1 and h2 are used.

  • You didn't remove the closing style tag.

  • You could wrap the old price in a del https://developer.mozilla.org/en-US/docs/Web/HTML/Element/del

  • Do not use pixel for font-size, instead, use 'em' or 'rem' (1rem = 16px).

  • Your css looks overcomplicated. You could simplify it a lot by using the right properties at the right time. Same for the naming, for example, class="perfume" doesn't make sense. Should be category or something.

  0