Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product-preview-card-component

@Baegan-189

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Boris 2,870

@mkboris

Posted

Nice work Baegan-189, just a few things to look at

  • Responsive images are handled using the picture element. Using CSS to hide and show images to display differently on various screen sizes is not part of the best practices.
  • All content should be wrapped within landmarks. Wrap a main tag around card. and a footer for the attribution.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
  • It's best practice linking Google fonts directly in the HTML head section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
  • Media queries should be defined in rem not px.

Hope this helps

0

@Baegan-189

Posted

Thank you @mkboris, It is very helpful i'll try to implement it.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord