Boris• 2,870
@mkboris
Posted
Nice work Baegan-189, just a few things to look at
- Responsive images are handled using the
picture
element. Using CSS to hide and show images to display differently on various screen sizes is not part of the best practices. - All content should be wrapped within landmarks. Wrap a
main
tag around card. and afooter
for the attribution. - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
- It's best practice linking Google fonts directly in the HTML
head
section rather than directly in your CSS file as it enables asynchronous downloading, improving page load times. - Font-size should be written in
rem
not px. This article explains it better Why font-size must NEVER be in pixels. - Media queries should be defined in
rem
not px.
Hope this helps
0
Baegan-189• 90
@Baegan-189
Posted
Thank you @mkboris, It is very helpful i'll try to implement it.
0