Product preview card component solution

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  replace <div class="container"> with the main tag , <h3></h3> and <h4></h4> with <p></p>, to fix the accessibility issues There is no need to give the body a width value, a margin value and a padding value. Give the body a background-color.

  To center a content on a page, add min-height:100vh; display: flex; align-items-center: justify-content: center; to the body. There is no need to give .container background-color: white and margin value. Add background-color: white; to .text-container.

  You forgot to add a media query for the mobile design.

  Hope am helpful Happy coding

  Marked as helpful

  0

  ---

  

  Natasha B.•90

  @nbuyldingPosted almost 2 years ago

  @Hassiai Thanks, I appreciate the feedback and tips!

  0
• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  The preview button doesn't open the project

  0

  ---

  

  Natasha B.•90

  @nbuyldingPosted almost 2 years ago

  @catherineisonline thanks for letting me know!

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0