Product Preview Card Component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution may cause accessibility errors due to lack of semantic markup, which causes lacking of landmark for a webpage and allows accessibility issues to screen readers, due to accessibility errors our website may not reach its intended audience, face legal consequences, and have poor search engine rankings, highlighting the importance of ensuring accessibility and avoiding errors.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>. They are use to provide a more precise detail of the structure of our webpage to the browser or screen readers

  ---

  • For example:
    • The <main> element should include all content directly related to the page's main idea, so there should only be one per page
    • The <footer> typically contains information about the author of the section, copyright data or links to related documents.

  ---

  • So resolve the issue by replacing the <div class="attribution"> element with the proper semantic element <footer> in your index.html file to improve accessibility and organization of your page

  ---

  BODY MEASUREMENTS 📐:

  • The width: 1440px property for body is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • So feel free to remove width: 1440px; style rule from body this will help you to write efficient code and makes your code more reusable.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  Phinda•140

  @Phinda824Posted over 1 year ago

  Thank you so much for your help @0xAbdulKhalid

  0
• 

  Shivraj K•400

  @Shivraj-K09Posted over 1 year ago

  • To add an icon to your code, you can use the <img> element in HTML. The src attribute specifies the URL or file path of the image file. In your code, you have an error in the source attribute for the image. Instead of "icon-cart.svgs" it should be "icon-cart.svg".
  • To make your code responsive for mobile devices, you can use media queries in your CSS. Media queries allow you to apply different styles based on the screen size or device type. You can use media queries with the @media rule, followed by the screen width and any additional rules you want to apply.

  Marked as helpful

  0

  ---

  

  Phinda•140

  @Phinda824Posted over 1 year ago

  I thank you, I didn't notice that error. @Shivraj-K09

  0