Basic HTML & CSS approach - first Flexbox project

Community feedback

• 

  Nikola D•1,510

  @NikolaD93Posted almost 2 years ago

  Hello there! 👋

  Congrats for completing the challenge! 🙌

  The code looks clean and the design is great, looks like you still got it!

  I would just not leave the product__image div empty however, but I can see you added an image in CSS later, which is not bad also.

  Hope this was helpful for you!

  Happy holidays! 🎉✌

  Marked as helpful

  1

  ---

  

  P

  Ryan Hemrick•290

  @Ryan-HemrickPosted almost 2 years ago

  @Nikola1232456 Thank you for the feedback! I look forward to diving into more projects!

  Happy holidays!

  1
• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Since the images in this component add value and serve a purpose (displaying the product) it needs to be accessible ⚠️. The image needs to be applied using the picture element and not the background-image property, as it will not only let you use different images during different breakpoints it will let apply an alt tag description to image stating what the image is.

  • The only heading ⚠️ in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a paragraph element.

  • Currently, the old price (169.99) 🏷 is not being properly announced 😢 to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using this unit gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  0

  ---

  

  P

  Ryan Hemrick•290

  @Ryan-HemrickPosted almost 2 years ago

  @vcarames Thank you for all of this feedback! The <picture> element was one that I never really used when I first dove into HTML and CSS back in 2015. I'll do some more studying on all of the info you provided to help give me some more perspective

  Thank you!

  1

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  @Ryan-Hemrick

  Glad I could help! 😁

  0