Responsive product

Community feedback

• 

  Rostyslav Nazarenko•560

  @rostyslav-nazarenkoPosted almost 2 years ago

  Hi! 😁

  Your solution looks excellent but doesn't correspond to the provided style guide. And there're a few issues with semantic HTML and accessibility.

  • Semantic HTML Semantic elements Better read for more understanding

    • there can be only one main element that represents your main content of the page. So in this challenge, all content should be put inside the main tag
    • footer and header elements cannot be nested within each other and they need to share the same parent element. I would delete these tags and use something else like general div elements
    • use h1 for the name of the product as the accessibility report suggests

  • CSS

    • your text is too small to read, the style guide says the main text should be 14px but yours is 7.52px
    • use relative units em or/and rem for accessibility so the users can provide their own font size. Please read this article about using absolute and relative units
    • there're other issues like using fixed height and width but I'm not sure so would stop here

  Have a great day

  Marked as helpful

  0

  ---

  

  Guilherme Fernandes Vidotti•520

  @VidottizzzPosted almost 2 years ago

  @rostyslav-nazarenko thank you so much!

  0