Responsive product preview card using HTML and CSS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The alt tag description for the image needs to be improved upon. Assume you’re describing the image to someone over the phone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • Implement a Mobile First approach 📱 > 🖥 Mobile devices are now the dominant 👑way in which people browse the web, it is critical that your website/content looks presentable on all mobile devices.

  More Info: 📚

  Mobile First

  • Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice to use em for media-queries. Using these unit gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎄🎁

  Marked as helpful

  1

  ---

  

  Nenad Fluka•50

  @nflukaPosted almost 2 years ago

  Hi @vcarames , thank you for taking the time to comment, and for pointing out the flaws in my HTML and CSS, this will help me a lot in the future challenges.

  1

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @nfluka

  Glad I could help! 😁

  0
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace<div class="container">with the main tag and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

  In the media query, change the width of .container by reducing it. e.g .container{width: 320px}. change the image to the mobile image and add display: block to the img and give .card_content a width of 100%.

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  1