@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- The
alt tag
description for the image needs to be improved upon. Assume you’re describing the image to someone over the phone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
del
element and inside it you will add aspan
element with ansr-only class
that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
- Implement a Mobile First approach 📱 > 🖥 Mobile devices are now the dominant 👑way in which people browse the web, it is critical that your website/content looks presentable on all mobile devices.
More Info: 📚
- Your
CSS Reset
is being underutilized. To fully maximize it, you will want to add more to it.
Here are some examples that you can freely use:
- For improved accessibility 📈 for your content, it is best practice to use
em
formedia-queries
. Using these unit gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎄🎁
Marked as helpful
@nfluka
Posted
Hi @vcarames , thank you for taking the time to comment, and for pointing out the flaws in my HTML and CSS, this will help me a lot in the future challenges.
@VCarames
Posted
@nfluka
Glad I could help! 😁