Product preview card component

Community feedback

• 

  Adriano•38,410

  @AdrianoEscarabotePosted about 1 month ago

  Hi Kairo, how are you doing? I really loved the outcome of your project, but I have a few suggestions that I think might be helpful:

  Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.

  <h1>Gabrielle Essence Eau De Parfum</h1>
  

  images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader.

  Learn the differences between decorative/meaningless images vs important content.

  The rest is excellent.

  I hope you find it useful. 👍

  Marked as helpful

  1

  ---

  

  Kairo•170

  @ChikairoPosted about 1 month ago

  Points well taken. Thank you so much @AdrianoEscarabote.

  1
• 

  P

  Tonyac-create•220

  @Tonyac-createPosted about 1 month ago

  You don't use a good semantic. You can use balise section, article, header and footer.

  0

  ---

  

  Kairo•170

  @ChikairoPosted about 1 month ago

  Thanks @Tonyac-create. Will try using an article next time or a header, but sometimes I get so lost on when to use them

  0

  

  P

  Tonyac-create•220

  @Tonyac-createPosted about 1 month ago

  You have this : https://fr.w3docs.com/apprendre-html/les-elements-semantiques-html5.html. It's the first step to know the different way to use semantic. 😁

  1

  

  Kairo•170

  @ChikairoPosted about 1 month ago

  Thanks @Tonyac-create

  0