Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
To better identify the main content of you site you will want to encase your entire component inside a Main Element.
-
The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
-
This challenges requires the use of two images 🎑 for different breakpoints. The Picture Element will facilitate this.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:
https://www.w3schools.com/html/html_images_picture.asp
https://web.dev/learn/design/picture-element/
- The only heading in this challenge is the name of the perfume, “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a Paragraph Element.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
0 -
- @Toch007Posted about 2 years ago
Great job buddy. The transition on your project was so smooth that I had to check out your code. However, I noticed that your code is a Responsive Web Design because you have a different folder for mobile CSS and the Main CSS and you avoided using the Media query. The height of your object on the main view and the width of your object on the mobile view is excess in my opinion. I think you need to work on that also. Apart from the little issues I raised, I believe your job is good to go.
0@HrHasnaiPosted about 2 years ago@Toch007 Feedback accepted. Thank you, buddy, for your valuable feedback.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord