- Very dark blue: hsl(212, 21%, 14%) - Dark grayish blue: hsl(228, 12%
Design comparison
Solution retrospective
all feedback is welcomed!!
Community feedback
- @matusalab-devPosted almost 2 years ago
let's start from the semantic part: I recommend you to use a section other regioning / sectioning semantic HTML to your container, a heading tag for your "perfume name", "p" tag is perfect for description, I think using a "p" tag for the price numbers rather "span" that are non-descriptive. the other is a layout problem the container is not perfectly centered. the right section doesn't have enough space as the design, giving both the same width will help to fix. last one, stop using the position property for this layout it's overkill instead use the flexbox alignment property. and try to determine the height of container by the content of the items.hope, this will help you to improve.
Marked as helpful0@akhribabderahmanePosted almost 2 years ago@mtslabrh97 I really appreciate your remarks .... thank you for your help.
1@matusalab-devPosted almost 2 years ago@akhribabderahmane it's my pleasure to help others. feel free to ask to contact me for any that I can.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord