Design comparison
Solution retrospective
I realised I have a lot more to learn when it comes to resizing images to fit into containers, I spent way too long trying to figure out why the product image was overflowing, I'm still not 100% certain I know why.
Community feedback
- @HassiaiPosted over 1 year ago
Replace <section id="cardContainer"> with the main tag and <div class="attribution"> with the footer tag to make the page accessible. click here for more on web-accessibility and semantic html
There is no need to give the body a min-width.
For a responsive image that will change the images at different screen sizes use the picture tag. For more click here
You dont need to resize the image to fit into the container, give the img a width of 100% ad display: block and it will fit into the container. for a responsive image that will shrink as the screen size reduces and becomes bigger as the screen size increases give the img a max-width of 100%.
Use the colors that were given in the styleguide.md found in the zip folder you downloaded.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord