Product preview card component

Community feedback

• 

  Thaís Vieira•120

  @thaisavieiraPosted about 2 years ago

  Hello, Karol! Congratulations on your solution, it's pretty close to the asked design and responsive! I checked your code and I noticed to you didn't write your own read.me file. I would appreciate reading your path to this challenge. Also, I notice in your index.html at the 24 line you write:

  <p>P E R F U M E</p> If you would like it's possible to uppercase letters with CSS too. But this is just a little detail. I love your work, keep going. You're awesome!

  Marked as helpful

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hi Karol, congrats on completing this challenge!

  Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you: You did a good work putting everything together in this challenge, something you can do to improve the image that needs to change between mobile and desktop is to use <picture> instead of <img> wrapped in a div. Look that for SEO and search engine reasons isn’t a better practice import this product image with CSS since this will make harder to the image be found. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  0