Product preview card component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello @tiger8707, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  1.It's even better to use relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

  2.When you download the project files there’s a file called style-guide.md where you can find information such as hsl color codes and the font-size for the headings.This is the correct color for the background body { background-color: #F3EBE4);}

  3.Using <picture> you’ve more control over the elements and its better than using the product image as <img> or background-image. Look that for SEO and search engine reasons it isn't a better practice to import this product image with CSS since this will make it harder to the image. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Omar Jalal•110

  @omar-jalalPosted about 2 years ago

  @correlucas Thanks, didn't know about the <picture> tag it's exactly what i needed!

  0