Product preview card component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  PiCTURE TAG 📸:

  • Looks like you're currently using media queries for swapping different version of image, So let me introduce the picture element.

  ---

  • The <picture> tag is commonly used for responsive images, where different image sources are provided for different screen sizes and devices, and for art direction, where different images are used for different contexts or layouts.

  ---

  • Example:

  <picture>
  <source media="(max-width: 768px)" srcset="small-image.jpg">
  <source media="(min-width: 769px)" srcset="large-image.jpg">
  <img src="fallback-image.jpg" alt="Example image">
  </picture>
  

  ---

  • In this example, the <picture> tag contains three child elements: two <source> elements and an <img> element. The <source> elements specifies different image sources and the conditions under which they should be used.

  ---

  • Using this approach allows you to provide different images for different screen sizes without relying on CSS, and it also helps to improve page load times by reducing the size of the images that are served to the user

  ---

  • If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0

  ---

  

  supakorn klampod•220

  @BKvipPosted over 1 year ago

  @0xAbdulKhalid Thank you very much for the new knowledge. I never knew about this.

  0
• 

  _nehal💎•6,710

  @NehalSahu8055Posted over 1 year ago

  Hello Coder 👋.

  Congratulations on successfully completing the challenge! 🎉

  Few suggestions regarding design.

  • Follow semantics rule place <header> outside and top of <main>.

  • Replace height:100vh with min-height:100vh in the body.

  • For image like .svg are decorative which browser will not render it to be important and skip it, so it makes no sense to add alt and leave it blank.

  <img src="image.svg" alt="">

  • Use responsive units(rem, em, %) from next project. Explore respective use cases on google. link

  • Try to add accessibility features like aria, sr-only, title.

  aria : link

  .sr-only:link

  I hope you find this helpful.

  Happy coding😄

  Marked as helpful

  0

  ---

  

  supakorn klampod•220

  @BKvipPosted over 1 year ago

  @NehalSahu8055 thank you. I'll improve

  1