Product preview card component

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello Yiwen Chen, congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code to improve the html markup/semantic:

  THE PICTURE TAG is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Yiwen Chen•190

  @CHEN-YiWenPosted about 2 years ago

  @correlucas Thank you so much for the suggestion! I didn't the existence of <code><picture></code>! It is definitely going to make placing the images much easier. I will try it out. Thanks again😄

  0
• 

  Laharl•1,000

  @UrbanskiDevPosted about 2 years ago

  Hello Yiwen Chen !

  Congratulation for finishing your project

  Some suggestions to make it better !

  1. You used an hover effect on your button, which is a good design idea to use, but the change is kinda brutal. You can make it smoother by adding a transition on your button !

  transition: 0.3s ease-in-out;
  

  I give you a like about transition on a button to learn more about it :

  • MDN Button Hover Transition

  2. In your HTML files, you can use the latest HTML semantic available ! You can replace your <div class=container> </div> with a <main></main> tag. It is important because a div tag doesn't have any meaning by default while a main tag has a meaning !

  I give you a link about HTML semantics :

  • W3Schools Semantic

  I hope it helps you, keep learning and happy coding !

  Marked as helpful

  0

  ---

  

  Yiwen Chen•190

  @CHEN-YiWenPosted about 2 years ago

  @UrbanskiDev Hi! Thanks for the suggestions again. It's really helpful😊 I didn't realize that I could use a transition to make the hover effect look smoother!

  0