Product preview card component

Community feedback

• 

  S MD suleman•3,530

  @sulemaan7070Posted almost 2 years ago

  Hey yuvan😄, I have inspected your site and here a few improvements you can make.

  1. There is some spacing around the image which is not letting it look like the design.
  2. And most importantly even on the desktop version the image is still the mobile-screen's image.. It is not changing.. you can fix that Hope my feedback helps you😁

  Marked as helpful

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The alt tag description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  • The attribution should be wrapped in a footer element.

  • Do not use internal CSS. Always use a separate file for all your CSS code.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0