Product Preview Card Component

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 6 months ago

  Hello @jopascensao!

  Your project looks great!

  I have a suggestion about your code that might interest you:

  📌 You can use the <picture> tag when you have different versions of the same image.

  Using the <picture> tag will help load the correct image to the user's device, saving bandwidth and improving performance.

  Example:

  <picture>
      <source media="(min-width: 768px)" srcset="{desktop image path here}">
      <img src="{mobile image path here}" alt="{alternative text here}">
  </picture>
  

  I hope this helps!

  Other than that, excellent work!

  0
• 

  Bernardo Poggioni•5,280

  @R3ygoskiPosted 6 months ago

  Hello @jopascensao, your project is good, but it had an alignment issue.

  If you want to fix the alignment, you can add this snippet to your body selector:

  body {
      height: 100vh;
      display: flex;
  }
  

  If you choose this approach, remember to remove the margin.

  Another tip, I noticed that your HTML lacks semantics, it's advisable to make it semantic because it helps with accessibility.

  An example of a tag that could be changed is this one: <div id="container">, which could be replaced with <main>, because that's where the main content of the page is located.

  0