Product Preview Card Component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Marco Louis , congrats on completing this challenge!

  I saw your solution preview site and I think it's already really good. Here’s some tips for you to improve it:

  The approach you've used to center this card vertically is not the best way, because using margins you don't have much control over the component when it scales. My suggestion is that you do this alignment with flexbox using the body as a reference for the container.

  REMOVE THE MARGIN

  @media screen and (min-width: 1170px)
  section {
      /* margin-top: 3rem; */
  }
  

  The first thing you need to do is to remove the margins used to align it, then apply min-height: 100vh to make the body height size becomes 100% of the screen height, this way you make sure that whatever the situation the child element (the container) align the body with display: flex and align-items: center / justify-items: center.

  body {
      min-height: 100vh;
      font-family: var(--ff-primary);
      line-height: 1.5;
      font-size: 0.875rem;
      background: var(--clr-primary-2);
      display: flex;
      align-items: center;
      justify-content: center;
  }
  

  ✌️ I hope this helps you and happy coding!

  0