card component in desktop and mobile using css
Design comparison
Community feedback
- @catherineisonlinePosted almost 2 years ago
Nice! ππ»
I would also add some transitions for active states (when colors change on hover). It creates more interactivity and makes the project looks cooler. Active states can be done on buttons, links, titles which act like links or anything else, you choose.
You can read more about it here, in case you havenβt done much of it:β¨https://www.w3schools.com/css/css3_transitions.asp
IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL π€©
Marked as helpful1@andreimaierPosted almost 2 years ago@catherineisonline Thank you for the feedback!
0 - @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- Since the images in this component add value and serve a purpose (displaying the product), it is best to use the
Picture
element and not thebackground-image
property, as it will to use different images during different breakpoints.
Here is an example of how it works: EXAMPLE
Syntax:
<picture> <source media="(min-width: )" srcset=""> <img src="" alt=""> </picture>
More Info:π
https://www.w3schools.com/html/html_images_picture.asp
- Currently, the old price (169.99) π· is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
del
element and inside it you will add aspan
element with ansr-only class
that will state something like βThe previous price wasβ¦β and use CSS to make it only visible to screen readers.
More Info:π
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!ππ
Marked as helpful1@VCaramesPosted almost 2 years ago@andreimaier
Glad I could help!
Keep it up!
0 - Since the images in this component add value and serve a purpose (displaying the product), it is best to use the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord