HTML and CSS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The image’s alt tag description needs to be improved upon to better describe what it is. You will want to assume that you are describing the image to a someone.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • This component requires the use of two images 🎑 at different breakpoints. The picture element will facilitate this.

  Here is an example of how it works: EXAMPLE

  Syntax:

    <picture>
      <source media="(min-width: )" srcset="">
      <img src="" alt="">
    </picture>
  

  More Info:📚

  https://www.w3schools.com/html/html_images_picture.asp

  • The only heading in this component, is the name of the perfume; “Gabrielle Essence Eau De Parfum” . The rest of the text should be wrapped in a paragraph element.

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

  More Info:📚

  Del Element

  • Your "button" was created with the incorrect element. It should be created using the button element. So that when the user clicks on the button (with the help of JS) it should add the product to the cart.

  More Info:📚

  MDN The Button element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1

  ---

  

  Lucas Bailo•100

  @lucasbailoPosted almost 2 years ago

  @vcarames Thanks for helping me bro!

  It was very helpful. About the screen reader, I had never heard about until now!

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  @lucasbailo

  I am glad that I was able to help out!

  Keep it up!

  1
• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  I would add some hover effect for the button and also the previous price is supposed to be grayish, not green 🙌🏻

  1

  ---

  

  Lucas Bailo•100

  @lucasbailoPosted almost 2 years ago

  @catherineisonline Yeah, I forgot about the hover effects! Thank you for the feedback!

  0

  

  Lucas Bailo•100

  @lucasbailoPosted almost 2 years ago

  @catherineisonline It's done! =D

  0