@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- The
alt tag
description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a
del
element and inside it you will add aspan
element with ansr-only class
that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.
More Info:📚
-
- Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful
@AlexKolykhalov
Posted
@vcarames thank you for clarifications! Еspecially for <del> tag
@VCarames
Posted
@AlexKolykhalov
Glad I could help!☃️
Keep it up!
@AlexKolykhalov
Posted
@vcarames another question... about resetting the CSS code. If I don't use some elements from the reset, do I need to write them in reset section?
@VCarames
Posted
@AlexKolykhalov
Even if you don’t use some of the reset properties, it is better to just have a complete list so that way all have to do is upload your reset file to project whenever you start a new challenge.
@AlexKolykhalov
Posted
@vcarames ok, thank you