Product preview card component

Hello there 👋. Good job on completing the challenge !

I have some feedback for you if you want to improve your code.

Questions:

• In my humble opinion, I think you have used the BEM naming convention correctly.

• You can use the <picture> tag when you have different versions of the same image 🖼. Using the <picture> tag will help you to load the correct image for the user's device saving bandwidth and improving performance. You can read more about this here 📘.

  Example:

  <picture>
      <source media="(min-width: 1440px)" srcset="./images/image-product-desktop.jpg ">
      <img src="./images/image-product-mobile.jpg" alt="{your alt text goes here}">
  </picture>
  

HTML 📄:

• Use the <main> tag to wrap all the main content of the page instead of the <div> tag. With this semantic element you can improve the accessibility of your page.

• Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

• Having two or more h1 tags in a webpage is not recommended because it can be confusing for search engines. Search engines use the h1 tag to determine the main topic of a page. <h1 class="product__current-price">$149.99</h1> should not be level-one heading

• You could use the <del> tag to indicate the price that was before the discount. Additionally, you can use a sr-only class to describe the discount. This will help screen reader users to understand that the price was discounted.

  Example: <del><span class="sr-only">Old price: </span>$169.99</del>

CSS 🎨:

• Instead of using pixels in font-size, use relative units like em or rem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here 📘.

I hope you find it useful! 😄 Above all, the solution you submitted is great!

Happy coding!