Abdul Khaliq 🚀• 72,580
@0xabdulkhaliq
Posted
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
HTML 🏷️:
- This solution contains some minor semantic issues which may cause lack accessibility
- The
<p>P E R F U M E</p>
, must want to be changed to normal case likePerfume
- Providing uppercase letter to them is not a good practice and the screen reader will read it as letter by letter like
P
,E
,R
etc.
- Don't worry we can use
text-transform: uppercase
to transform the letter andletter-spacing: 1rem
for the textPerfume
- And another thing that the old price is not being properly announced, you have used
p
element for that.
- Actually there's a native html element which comes handy in these situations. it is
del
element
- So you can use like this
<del>$169.99</del>
- These are the tips which improves the accessibility in real world situations.
- If you have any questions or need further clarification, you can always check out
my submission
and/or feel free to reach out to me.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
1
BotAldaris• 140
@BotAldaris
Posted
@0xAbdulKhalid thanks for the feedback, I really appreciate it
0
Abdul Khaliq 🚀• 72,580
@0xabdulkhaliq
Posted
@BotAldaris Glad you found it helpful ! 🤠
0