Skip to content
Submitted over 1 year ago

Product preview card component

Vinicius - Souza•410
@vinicius-pereira-souza
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • IryDev•1,580
    @IryDevPosted over 1 year ago

    Hey, well done for completed this challenge😁

    I have some suggestions to help you to improve your solution :

    • your card seem to not be correctly centered
    • Give the body a min-height of 100vh
    • Add the property , display: flex; justify-content: center; align-items: center; to make the card center on the vertical axis and horizontal axis
    • Replace the <div class="attribution"> by the semantic <footer> tag

    HTML :

    <body>
      <footer class="attribution">
            information about author copyright etc
      </footer>
</body>

    CSS :

    body {
  min-height: 100vh;
  display: flex;
  align-items: center;
  justify-content: center;
}

    I also make pull requests on your Github repo so you can merge it if the changes suit you

    I hope you'll find this helpful, and your solution is really good 😄

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord