Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

My Product Preview Card Component Solution Using Grid and Flexbox

Linda B 270

@Lynd7

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Hassia Issah 50,670

@Hassiai

Posted

Use rem or em as unit for the padding, margin and width. The rem unit is relative to the browser, its default value 16px and can be changed by the user. for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

In the media query replace display: inline flex with display: flex; and the height value with auto instead of the fixed value if there is a thin line beneath the image add display: block to the img.

Hope am helpful

Well done for completing this challenge. HAPPY CODING

Marked as helpful

1

@VCarames

Posted

👾 Hey there! 👋 Here are some suggestions to help improve your code: 👾

  • The image is not decorative, so it should no be hidden to assistive technology. Inside the alt tag it should describe what the image is; they need to be readable. Assume you’re describing the image to someone.

More Info:📚

https://www.w3.org/WAI/tutorials/images/

  • Currently, the old price (169.99) 🏷 is not being properly announced to screen readers. To fix this, you are going to wrap the the price in a del element and inside it you will add a span element with an sr-only class that will state something like “The previous price was…” and use CSS to make it only visible to screen readers.

More Info:📚

Del Element

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🎄🎁

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord