Product Preview Card Component

Community feedback

• 

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  HEY TIM!

  CONGRATULATIONS ON COMPLETING YOUR FIRST CHALLENGE

  Your solution looks nice, however, I noticed that the hover effect for the button was not included, I have done this challenge before and although the required color was not included in the style guide, you can just use a darker green.

  The spacing on your mobile design seems to be too much, you should try reducing it.

  To fix the error on your accessibility report, instead of using a div for the .attribution, you should consider using a more semantic element like footer, doing so not only makes your page more accessible for disabled people, but you will also have one less error on your report.

  HOPE I COULD BE OF HELP :)

  HAPPY CODING!

  0

  ---

  

  Tim Hart•60

  @timhart83Posted almost 2 years ago

  @Nadine-Green Hey thanks for the feedback. I forgot to commit my hover effect change haha. all sorted though now.

  I didn't play around with the attribute section but will go back and take a look at that and then bear those in mind moving forwards.

  0

  

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  @timhart83

  Happy that I could be of help

  1