Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card Component

Tim Hart 60

@timhart83

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Favour 2,140

@Nadine-Green

Posted

HEY TIM!

CONGRATULATIONS ON COMPLETING YOUR FIRST CHALLENGE

Your solution looks nice, however, I noticed that the hover effect for the button was not included, I have done this challenge before and although the required color was not included in the style guide, you can just use a darker green.

The spacing on your mobile design seems to be too much, you should try reducing it.

To fix the error on your accessibility report, instead of using a div for the .attribution, you should consider using a more semantic element like footer, doing so not only makes your page more accessible for disabled people, but you will also have one less error on your report.

HOPE I COULD BE OF HELP :)

HAPPY CODING!

0

Tim Hart 60

@timhart83

Posted

@Nadine-Green Hey thanks for the feedback. I forgot to commit my hover effect change haha. all sorted though now.

I didn't play around with the attribute section but will go back and take a look at that and then bear those in mind moving forwards.

0
Favour 2,140

@Nadine-Green

Posted

@timhart83

Happy that I could be of help

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord