Design comparison
Solution retrospective
Any suggestions and recommendation in my code is well appreciated 😊
Community feedback
- @SinisaVukmirovicPosted almost 2 years ago
Hello!
All looks good!
If you are looking for ways to improve you code, consider implementing "mobile first" approach in your workflow.
More about mobile first approach
Why to implement mobile first
Hope this helps!
Marked as helpful0@kentbunoPosted almost 2 years ago@SinisaVukmirovic I'm actually doing a mobile first :) but thanks for the more info
0@SinisaVukmirovicPosted almost 2 years ago@kentbuno Indeed you do. Hm, weird... I must of was lucking at someone elses/another code, too.
I apologies!
Since I am already here, can I ask - is the 4 decimals REM sizes really needed? And do you really calculate it with a calculator every time?
Again, my apologies.
Marked as helpful0@kentbunoPosted almost 2 years ago@SinisaVukmirovic no that's actually a pixel I just used Marco's vscode extension called px to rem to convert it to rem :)
0 - @ebenezerogunremiPosted almost 2 years ago
Wow, this is very beautiful. 99% close to the original design. keep it up.
Marked as helpful0 - @jbidzPosted almost 2 years ago
Hi Kent, good job completing this challenge
I'm really amaze by the outcome of your solution. It's really close to the original design, but I think the shadow is too hard. Try increasing the blur and lowering the opacity.
.component { box-shadow: 0 0 30px rgba(0, 0, 0, 0.1); }
Happy Coding😊
Marked as helpful0@kentbunoPosted almost 2 years ago@jbidz Thanks :) I'll use your recommendation for the next challenge.
0 - @HassiaiPosted almost 2 years ago
Well done for completing this challenge, everything is good. This challenge does not require a box-shadow for the main. i.e box-shadow: 0rem 0rem 1.25rem 0.3125rem var(--primary-color); is not needed. In the mobile design give the main a percentage width value of 80.
Hope am Helpful Happy coding
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord