Product preview card component

Community feedback

• 

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 2 years ago

  Hey Lasha, this is a very neat solution congratulations on completing your first frontend mentor project 🥳 To answer your questions:

  1. Your code is very neat and organized! Both the HTML and CSS, I wouldn't change anything apart from adding landmarks in your HTML because In order to resolve some of your accessibility issues, you might wanna use landmarks in your html code, these help browsers easily navigate your code. So you might consider wrapping your divs in landmarks like <main> or <header> or <footer> you need to do this according to how your page is structured. Incase you want to know more about landmarks, follow this link.
  2. Responsive design has always been a hustle for most people when starting out with CSS and I am no exception 😂 but you get the hang of it the more you practice making responsive designs and incase you'd just want to expand your knowledge with responsiveness you could check out this tutorial (Follow this link) [https://youtu.be/Xig7NsIE6DI]. I hope it helps you!

  Ps: Your heading tags should only increase by one ie when you have just used a <h1> tag, your next heading tag should be <h2> and after that <h3> and it continues like that all the way to <h6>. So they have to be in a sequential order. This will also clear some more of your accessibility issues.

  Happy coding and keep up the good work!

  Marked as helpful

  1

  ---

  

  Lasha•50

  @lashaarveladzePosted over 2 years ago

  @tesla-ambassador Thank you🤩 you helped me a lot

  1

  

  Lasha•50

  @lashaarveladzePosted over 2 years ago

  @tesla-ambassador Heyy I made a responsive design and there are no accessibility issues anymore. Thank you🥰 (The video was helpful)

  1

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted over 2 years ago

  @lashaarveladze You're welcome! I am glad that I could help and that the video was helpful.

  1