Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Preview Card Component

@joaovitorwitt

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedbacks are welcome, thank you in advance

Community feedback

@nzewi

Posted

Congrats on completing your first challenge JOAOVITORWITT

You have a great solution there

Here are my suggestions:

1.Use relative units like rem and em instead of px for spacing and font-sizes, this would make your site more responsive. Learn about them and use them in your next project.

2.Ensure that all content on your page is contained within a landmark region, e.g Wrapping your container-inner <div> inside a <main> tag. This makes your HTML more semantic and accessible. You can use other semantic tags like button instead of a div for buttons. Also, make sure you have only 1 h1 on your page

I hope this helps

Marked as helpful

0

@joaovitorwitt

Posted

@nzewi thank you for the suggestions, I will definitely learn more about relative units.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord