Design comparison
Solution retrospective
All feedbacks are welcome, thank you in advance
Community feedback
- @nzewiPosted about 2 years ago
Congrats on completing your first challenge JOAOVITORWITT
You have a great solution there
Here are my suggestions:
1.Use relative units like
rem
andem
instead ofpx
for spacing and font-sizes, this would make your site more responsive. Learn about them and use them in your next project.2.Ensure that all content on your page is contained within a landmark region, e.g Wrapping your container-inner
<div>
inside a<main>
tag. This makes your HTML more semantic and accessible. You can use other semantic tags likebutton
instead of adiv
for buttons. Also, make sure you have only 1h1
on your pageI hope this helps
Marked as helpful0@joaovitorwittPosted about 2 years ago@nzewi thank you for the suggestions, I will definitely learn more about relative units.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord