Skip to content
Submitted almost 2 years ago

Product preview card component main

Ahmed Essam•60
@AhmedEssam01
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Product preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted almost 2 years ago

    Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

    HTML:

    • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.
    • The <h1> is the most important heading on the page, In this challenge the perfumer's name can be considered like the title of the page, so it should be the <h1>
    • You could use the <del> tag to indicate the price that was before the discount. Additionally, you can use a sr-only class to describe the discount. This will help screen reader users to understand that the price was discounted.

    Example:

    <del><span class="sr-only">Old price: </span>$169.99</del>
    • The alt attribute is used to provide a text description of the image which is useful for screen reader users, assistive technology users, and search engine optimization. Add the alt attribute to the <img> tag.
    • Not all images should have alt text. The cart-icon is a decorative image, it does not add any information to the page. You should use an empty alt attribute instead of a descriptive one. You can read more about this here.

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding! 🎄

    Marked as helpful
    1
    Ahmed Essam•60
    @AhmedEssam01Posted almost 2 years ago

    @MelvinAguilar Thanks for helping, may you help me to solve this warning "Page should contain a level-one heading

    <html lang="en">"
    1
    Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted almost 2 years ago

    @AhmedEssam01 Hi! The level-one heading is the <h1> tag. The <h1> tag is the most important heading tag, also, there should only be one <h1> tag per page. The perfume's name is considered the level-one heading in this case

    You can read more about this here

    Marked as helpful
    1
    Ahmed Essam•60
    @AhmedEssam01Posted almost 2 years ago

    @MelvinAguilar Thanks very much i am going to do that

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord