responsive product card

Community feedback

• 

  S MD suleman•3,530

  @sulemaan7070Posted almost 2 years ago

  hey @med-redha😄, congratulations on completing the challenge.. here are a few tips to improve the site and code...

  1.On the mobile version you can display a separate image which you will find in the images -folder ... you can use the picture for responsively changing the image like this

  <picture>
    <source media="(min-width: 650px)" srcset="img_food.jpg">
    <source media="(min-width: 465px)" srcset="img_car.jpg">
    <img src="img_girl.jpg">
  </picture>
  

  2.you should use min-height:100vh instead of height:100vh;...

  3.you can remove the border around the button if it wasn't intentional...

  4.you can increase font-weight for the price text... let me know if you need any help happy coding🔥🔥

  Marked as helpful

  1

  ---

  

  Redha•90

  @med-redhaPosted almost 2 years ago

  hey @sulemaan7070 thank you for the advices i ll take them into consediration, i forgot that i have 2 pics one for mobile and one for desktop lol hence why i just made it work using css lol. thanx again for your feedback.

  1