Design comparison
SolutionDesign
Solution retrospective
Any feedback is helpful!
Community feedback
- @MelvinAguilarPosted about 2 years ago
Hi @Daniel3-14 ๐, good job completing this challenge! ๐
I have some suggestions you might consider to improve your code:
- The
<h1>
element is the main heading on a webpage, also, there should only be one<h1>
tag per page.<h1>$149.99</h1>
must not be a <h1> element.
- Add descriptive text to the
alt
attribute of the images. The text must clearly describe the image. The alt attribute enables screen readers to read the information about on-page images and will be displayed instead if an image file cannot load.
- Not all images should have alt text. The cart icon is for decoration purposes only, so it can be hidden from screen-readers by adding
aria-hidden="true"
and leaving its alt attribute empty:
<img class="cart-img" src="./images/icon-cart.svg" alt aria-hidden="true">
- You can use a <picture> tag when you need to change an image in different viewports. Using this tag will prevent the browser from loading both images, saving bandwidth and preventing you from utilizing a media query in your CSS file to modify the image.
Example:
<picture> <source media="(max-width: 530px)" srcset="./images/image-product-mobile.jpg"> <img src="./images/image-product-desktop.jpg" alt="your alt text"> </picture>
- You could use the <del> tag to display the old price:
<del> <span class="sr-only">Old price: </span>$169.99 </del>
Note that I added the <span> with the
sr-only
class to thedel
element, this will provide more information about what your old price is about.The
sr-only
class is a class that you can add to hide content visually but is only visible to screen-readers.I hope those tips will help you! ๐
Good job, and happy coding! ๐
0 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord