Design comparison
Solution retrospective
First challenge in frontend mentor.I am a beginner. Any feedback on how I can improve would be greatly appreciated.
Community feedback
- @MelvinAguilarPosted over 1 year ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML ๐ท๏ธ:
- Empty landmarks are not necessary, they just occupy unnecessary lines of code. You can remove
<header></header>
and<footer></footer>
.
-
You can use the
<picture>
tag when you have different versions of the same image ๐ผ. Using the<picture>
tag will help you to load the correct image for the user's device. You can read more about this here ๐.Example:
<picture> <source media="(max-width: 460px)" srcset="./images/image-product-mobile.jpg"> <img src="./images/image-product-desktop.jpg" alt="{your alt text goes here}"> </picture>
-
The
alt
attribute is used to provide a text description of the image which is useful for screen reader users, assistive technology users, and search engine optimization. Add thealt
attribute to the<img>
tag of the product.
I hope you find it useful! ๐
Happy coding!
0@SavindushehanPosted over 1 year ago@MelvinAguilar
thanks for your advice .I got this ideas .thank you very much.
0 - Empty landmarks are not necessary, they just occupy unnecessary lines of code. You can remove
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord