Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product preview card component

denise 230

@moncadad

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'd appreciate any feedback as well as any recommendations about how to make this project accessible.

Community feedback

@comradeintense

Posted

Looks pretty good! Regarding the accessibility part a thing I learned when I did this project, is that for people who are using a screen reader, the pricing will be spoken something like: one hundred forty nine dot ninety nine , one hundred sixty nine dot ninety nine.

So what you want to do is give some context just for the screen readers. Based on your code:

<div className="pricing">
<h1 className="sale-price">$149.99</h1>
<p className="price">$169.99 </p>
</div>

you could add two paragraphs or spans with a class like "visually-hidden" like so:

<div className="pricing">
<span className="visually-hidden">Current price on sale:</span>
<h1 className="sale-price">$149.99</h1>
<span className="visually-hidden">Original price:</span>
<p className="price">$169.99 </p>
</div>

And then in the css:

.visually-hidden {
position: absolute;
position: absolute !important;
width: 1px !important;
height: 1px !important;
padding: 0 !important;
margin: -1px !important;
overflow: hidden !important;
clip: rect(0,0,0,0) !important;
white-space: nowrap !important;
border: 0 !important;
}

This will hide the spans in the browser, but will be read by screen readers. The CSS I got from here: Orange Accessibility

If you ever use TailwindCSS - there is a utility class called "sr-only" which does exactly the same thing.

Hope it helps!

Marked as helpful

0

denise 230

@moncadad

Posted

@comradeintense Thank you for the feedback I'll be looking into those resources, and implementing the tips.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord